Skip to content

Conversation

@dilipbiswal
Copy link
Contributor

@dilipbiswal dilipbiswal commented Jun 22, 2020

What changes were proposed in this pull request?

A minor PR that adds a couple of usage examples for ArrayFilter and ArrayExists that shows how to deal with NULL data.

Why are the changes needed?

Enhances the examples that shows how to filter out null values from an array and also to test if null value exists in an array.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested manually.

…de examples of IS NULL and IS NOT null predicate
@dilipbiswal
Copy link
Contributor Author

cc @HyukjinKwon

@HyukjinKwon HyukjinKwon changed the title [SQL][MINOR] Update expression description of ArrayFilter and ArrayExists to include examples of IS NULL and IS NOT null predicate [MINOR][SQL] Update expression description of ArrayFilter and ArrayExists to include examples of IS NULL and IS NOT null predicate Jun 22, 2020
@SparkQA
Copy link

SparkQA commented Jun 22, 2020

Test build #124350 has finished for PR 28890 at commit 1f915e4.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor Author

retest this please

@dongjoon-hyun dongjoon-hyun changed the title [MINOR][SQL] Update expression description of ArrayFilter and ArrayExists to include examples of IS NULL and IS NOT null predicate [MINOR][SQL] Add IS [NOT] NULL examples to ArrayFilter/ArrayExists Jun 22, 2020
@SparkQA
Copy link

SparkQA commented Jun 22, 2020

Test build #124353 has finished for PR 28890 at commit 1f915e4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jun 22, 2020

Merged to master and branch-3.0.

HyukjinKwon pushed a commit that referenced this pull request Jun 22, 2020
### What changes were proposed in this pull request?
A minor PR that adds a couple of usage examples for ArrayFilter and ArrayExists that shows how to deal with NULL data.

### Why are the changes needed?
Enhances the examples that shows how to filter out null values from an array and also to test if null value exists in an array.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
Tested manually.

Closes #28890 from dilipbiswal/array_func_description.

Authored-by: Dilip Biswal <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit 6293c38)
Signed-off-by: HyukjinKwon <[email protected]>
@dilipbiswal
Copy link
Contributor Author

dilipbiswal commented Jun 22, 2020

Thank you @HyukjinKwon @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants